Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vote-939: Language Selector Style Refinements #654

Merged
merged 13 commits into from
Apr 22, 2024

Conversation

clmedders
Copy link
Contributor

@clmedders clmedders commented Apr 15, 2024

Jira ticket

Vote-939

Description

Updating language selector styles based on refinement review

Deployment and testing

Pre-deploy

n/a

Post-deploy

n/a

QA/Test

  1. Pull down branch to your local and run lando retune and cd into the votegov theme and run npm run build
  2. Navigate to a page that has been translated (about us page or state page) and verify the following -> A - The dropdown BG color is base-dark. B - the button color matches the drop down once you tab into the drop down menu

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@clmedders clmedders changed the title Vote-939: Language Selector Refinements Vote-939: Language Selector Style Refinements Apr 15, 2024
@clmedders clmedders marked this pull request as ready for review April 15, 2024 19:27
mlloydbixal
mlloydbixal previously approved these changes Apr 17, 2024
@rayestrada rayestrada merged commit b92361d into dev Apr 22, 2024
3 checks passed
@rayestrada rayestrada deleted the feature/vote-939-lang-updates branch April 23, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants