-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vote-939: Language Selector Style Refinements #654
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clmedders
changed the title
Vote-939: Language Selector Refinements
Vote-939: Language Selector Style Refinements
Apr 15, 2024
clmedders
commented
Apr 15, 2024
web/themes/custom/votegov/src/sass/uswds-overrides/usa-button.scss
Outdated
Show resolved
Hide resolved
clmedders
commented
Apr 15, 2024
web/themes/custom/votegov/src/sass/uswds-overrides/usa-language-selector.scss
Outdated
Show resolved
Hide resolved
clmedders
commented
Apr 17, 2024
web/themes/custom/votegov/src/sass/uswds-overrides/usa-language-selector.scss
Outdated
Show resolved
Hide resolved
mlloydbixal
previously approved these changes
Apr 17, 2024
rayestrada
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket
Vote-939
Description
Updating language selector styles based on refinement review
Deployment and testing
Pre-deploy
n/a
Post-deploy
n/a
QA/Test
lando retune
and cd into thevotegov
theme and runnpm run build
base-dark
. B - the button color matches the drop down once you tab into the drop down menuChecklist for the Developer
Checklist for the Peer Reviewers