Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VOTE-1007: feature card icon refinement #656

Merged
merged 4 commits into from
Apr 17, 2024
Merged

VOTE-1007: feature card icon refinement #656

merged 4 commits into from
Apr 17, 2024

Conversation

mlloydbixal
Copy link
Contributor

@mlloydbixal mlloydbixal commented Apr 16, 2024 •
edited
Loading

Jira ticket

VOTE-1007

Description

Updates feature icon fill and stroke colors

Deployment and testing

Pre-deploy

  1. Insert any required steps to take before merging and running post-deploy.

Post-deploy

  1. Insert any required steps to take before beginning test.

QA/Test

  1. npm run build
  2. add an icon to voter guide page
  3. add a feature card on homepage for that voter guide
  4. confirm icon scales correctly and uses correct fill/stroke colors
  5. hover over feature card and confirm colors are correct

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@mlloydbixal mlloydbixal requested a review from rayestrada April 16, 2024 14:37
@rayestrada rayestrada merged commit 3ac1f9b into dev Apr 17, 2024
3 checks passed
@rayestrada rayestrada deleted the feature/VOTE-1007/teaser-icon branch April 23, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rayestrada rayestrada rayestrada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mlloydbixal @rayestrada