Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VOTE-383: Add sandbox attribute to gtm iframe embed snippet. #661

Merged
merged 1 commit into from
Apr 22, 2024
Merged

VOTE-383: Add sandbox attribute to gtm iframe embed snippet. #661

merged 1 commit into from
Apr 22, 2024

Conversation

daniel-crowder
Copy link
Contributor

@daniel-crowder daniel-crowder commented Apr 18, 2024 •
edited by rayestrada
Loading

Jira ticket

VOTE-383

Description

Resolve security scan issue with iframe embed for Google Tag Manager.

Deployment and testing

Pre-deploy

N/A

Post-deploy

N/A

QA/Test

  1. Locally, run lando retune
  2. Load the site, inspect the source code, and confirm that the <iframe> tag for googletagmanager includes a 'sandbox' attribute.

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@rayestrada rayestrada merged commit f8831e9 into dev Apr 22, 2024
3 checks passed
@rayestrada rayestrada deleted the feature/VOTE-383-iframe-security branch April 23, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rayestrada rayestrada rayestrada approved these changes

Assignees

@rayestrada rayestrada

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daniel-crowder @rayestrada