Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vote-1103: Bug fix for footer hover effect #673

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

clmedders
Copy link
Contributor

@clmedders clmedders commented Apr 26, 2024

Jira ticket

Vote-1103

Description

Adjust vote-link mixin by adding !important flag on the hover effect color.

This was done because in web/themes/custom/votegov/src/sass/components/footer-primary.scss line 41, the color is also getting set with important so it is overriding the hover effect color. The update can also help down the road if there are any other colors that are set and would override the hover effect.

Deployment and testing

Post-deploy

  1. cd into votegov theme and run npm run build

QA/Test

  1. scroll to the footer and check that on hover the text color is white

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@clmedders clmedders requested a review from SamiraMSadat April 29, 2024 14:01
@clmedders clmedders marked this pull request as ready for review April 29, 2024 14:01
@clmedders clmedders merged commit 651ebd9 into dev Apr 30, 2024
3 checks passed
@rayestrada rayestrada deleted the bug/vote-1103-footer-hover branch May 21, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants