Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOTE-1086: Update Amharic translation #680

Merged
merged 4 commits into from
May 6, 2024

Conversation

daniel-crowder
Copy link
Contributor

@daniel-crowder daniel-crowder commented May 2, 2024

Jira ticket

VOTE-1086

Description

Update config files to include requested translation updates.

Deployment and testing

Post-deploy steps

  1. Insert any required steps to take before beginning test.

QA/Testing instructions

  1. Locally, run lando retune to import updated config and po changes.
  2. Login as an admin, and confirm that the changes have been updated by visiting /admin/config/regional/translate.
  3. Perform a filtered search for the original strings, using Amharic as the filter.
  4. Use the commit diff in this PR to identify the strings to search for.
  5. Confirm the long date change by visiting /admin/config/regional/date-time/formats/manage/long_date/translate
  6. Locate the 'Amharic' language in the list, click 'Edit' and confirm the format is 'l ዕለት F d ቀን Y'

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

Copy link
Contributor

@clmedders clmedders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

just want to note that i did a search of the original strings and was able to find them not sure if that was the expect result but the files look relevant and also was able to run a retune with no issues

@daniel-crowder daniel-crowder merged commit 9c92161 into dev May 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants