Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/vote 1131/footer px design updates #699

Merged
merged 17 commits into from
May 23, 2024

Conversation

SamiraMSadat
Copy link
Contributor

@SamiraMSadat SamiraMSadat commented May 13, 2024

VOTE-1131

Description

Implemented the PX design revisions of the footer. This includes both the structure of the footer, placement of components, and the styling.

Deployment and testing

Post-deploy steps

  1. lando retune
  2. Cd into the theme, run: npm run build

QA/Testing instructions

  1. Visit the homepage. Confirm it matches the designs in Figma for all the default breakpoints (left column).
  2. Confirm design matches for all the languages and that there are no regressions.

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@SamiraMSadat SamiraMSadat requested a review from rayestrada May 16, 2024 20:30
@SamiraMSadat SamiraMSadat marked this pull request as ready for review May 16, 2024 20:30
@rayestrada rayestrada merged commit 9e29aaa into dev May 23, 2024
3 checks passed
@rayestrada rayestrada deleted the feature/VOTE-1131/footer-px-design-updates branch June 18, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants