Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vote-1130: Life Events Refinements #701

Merged
merged 10 commits into from
May 22, 2024

Conversation

clmedders
Copy link
Contributor

@clmedders clmedders commented May 14, 2024

Jira ticket

Vote-1130

Description

Style Refinements for life events section on homepage.

Changes applied

  • updated content to match design
  • updated link to added hover effect
  • adjusted column use and offset
  • adjusted padding for break points

Figma Link

Deployment and testing

Post-deploy steps

  1. run lando retune then cd into votegov theme and run npm run build

QA/Testing instructions

  1. log into site and update the quick links section content to match design -> Heading: Have you changed your name, address, or party affiliation?, Content: You'll select your state or territory to get started., Link: Url /register Link Text - Check or update your registration
  2. figma Link for reference - review the default section on the far left at the various break points -> Mobile, tablet and desktop
  3. check that hover effect is working as expected (adding underline and arrow moves from 4px to 12px)
  4. check that no major visual regressions appear

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@clmedders clmedders changed the title Feature/vote 1130 life event refinements Vote-1130: Life Events Refinements May 15, 2024
@clmedders clmedders requested a review from SamiraMSadat May 15, 2024 15:24
@clmedders clmedders marked this pull request as ready for review May 15, 2024 15:24
@clmedders clmedders requested a review from SamiraMSadat May 16, 2024 14:48
SamiraMSadat
SamiraMSadat previously approved these changes May 16, 2024
@clmedders clmedders requested a review from rayestrada May 16, 2024 20:06
@rayestrada rayestrada merged commit 16b8da8 into dev May 22, 2024
3 checks passed
@rayestrada rayestrada deleted the feature/vote-1130-life-event-refinements branch June 18, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants