Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOTE-1135: Update content manager role permission #702

Merged
merged 5 commits into from
May 29, 2024

Conversation

daniel-crowder
Copy link
Contributor

@daniel-crowder daniel-crowder commented May 15, 2024

Jira ticket

VOTE-1135

Description

Allow content managers to publish landing pages.

Deployment and testing

Post-deploy steps

none

QA/Testing instructions

  1. Locally run lando retune
  2. Login as a user with the 'Content Manager' role. lando drush uli --name=username will allow you to login as a user with the Content Manager role.
  3. Go to the Content admin page, locate a Landing Page content item, click edit, and confirm that you have the publishing option below. Additionally, confirm that you can add a revision log entry too.
  4. Confirm the same for a translated version of the page.
  5. For other node types, confirm the workflow/moderation states work correctly and that you can add a revision log entry.

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@daniel-crowder daniel-crowder requested a review from rayestrada May 15, 2024 13:48
@daniel-crowder daniel-crowder changed the title VOTE-1135: Update workflow to include Landing Page content type. VOTE-1135: Update content manager role permission May 15, 2024
Copy link
Contributor

@rayestrada rayestrada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a solution where we can still restrict the roles ability to delete certain content types. This permissions is too permissive.

…ntent Managers publishing option for Landing Page node type.
@daniel-crowder daniel-crowder requested a review from rayestrada May 29, 2024 20:44
@rayestrada rayestrada merged commit 136258f into dev May 29, 2024
3 checks passed
@rayestrada rayestrada deleted the feature/VOTE-1135-update-content-manager-role branch June 18, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants