Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vote-1336: Breadcrumb to match page title case #726

Merged
merged 4 commits into from
May 30, 2024

Conversation

clmedders
Copy link
Contributor

@clmedders clmedders commented May 28, 2024

Jira ticket

Vote-1336

Description

Updating breadcrumb menu to match the page title... replaced the item.text with Drupal Title

Before and After
Before:
Screenshot 2024-05-28 at 12 00 21 PM

After:
Screenshot 2024-05-28 at 12 00 09 PM

Deployment and testing

Post-deploy steps

  1. run lando retune

QA/Testing instructions

  1. log in and visit a voter guide page, verify that breadcrumb is not matching the page title
  2. edit the page title and check that breadcrumb is still matching the page title. can also visit a state page and update the title case for the state title and should also be reflected in the breadcrumb

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@clmedders clmedders marked this pull request as ready for review May 28, 2024 16:56
clmedders added 3 commits May 29, 2024 21:33
Signed-off-by: christian medders <christian.medders@gsa.gov>
@clmedders clmedders requested a review from rayestrada May 30, 2024 01:35
@rayestrada rayestrada merged commit a33ba13 into dev May 30, 2024
3 checks passed
@rayestrada rayestrada deleted the feature/vote-1336-breadcrumb-titlecase branch June 18, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants