Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vote-1342: Adding comment for not adding external link icon #727

Merged
merged 1 commit into from
May 30, 2024

Conversation

clmedders
Copy link
Contributor

@clmedders clmedders commented May 28, 2024

Jira ticket

Vote-1342

Description

Adding a comment in the js file to give guidance of adding the extlinkjs-ignore attribute for icons

Deployment and testing

Post-deploy steps

n/a

QA/Testing instructions

  1. review comment and check that it provides direction for the use of the attribute

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@clmedders clmedders requested a review from mlloydbixal May 28, 2024 17:16
@clmedders clmedders marked this pull request as ready for review May 28, 2024 17:16
@clmedders clmedders requested a review from rayestrada May 30, 2024 01:47
@rayestrada rayestrada merged commit da15034 into dev May 30, 2024
3 checks passed
@rayestrada rayestrada deleted the feature/vote-342-remove-ext-icon branch June 18, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants