-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VOTE-1163/1162: Accessibility updates - logos and search AND regions #729
Conversation
Sprint 47: Release candidate to STAGE
MId-sprint 48: HOTFIX release
VOTE-570 add section alert field to nvrf field taxonomy
Sprint 48: release candidate to STAGE
Sprint 49: release candidate for STAGE
Sprint 50: release candidate to STAGE
Sprint 51: Release Candidate to STAGE
HOTFIX Sprint 52
Sprint 52: release candidate to STAGE
VOTE-541: remove taxonomy pages from static site after generation
HOTFIX for missing hmn configuration
HOTFIX clean out unused config
Sprint 53: release candidate to STAGE
Sprint 54: release candidate to STAGE
Sprint 54: addition
Sprint 55: Release candidate to STAGE
Sprint 56: release candidate to STAGE
Sprint 57: release candidate to STAGE
Sprint 58: Release candidate to STAGE
Sprint 59: Release candidate to STAGE
Sprint 59: additional fixes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - i checked that the logo had alt text and check that the others flagged already had them and did a screen reader check for the search bar
web/themes/custom/vote_gov/templates/paragraph/paragraph--registration-tool.html.twig
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment above.. also found a bug with the search field but will post in ticket
Jira ticket
VOTE-1163
VOTE-1162
Description
VOTE-1163
-Adds site logo alt text "Vote.gov - Home"
-No updates to USA logo alt text because it was already implemented
-No updates to GSA logo alt text because it was already implemented
-Adds aria label for search input to say "submit" instead of "commit"
VOTE-1162
-Switches nav elements for divs/sections in main section where they were not nav items (sitemap, registration tool)
-Removes the redundant "navigation" from "primary navigation"
-The vote.gov logo region issue was already resolved
-Removes redundant "search" and now just says "Search region"
-Identifier region now says ""External election resources"
-Removes "introduction region"
-The issue with the collage of images showing as a region doesn't appear to be an issue
Deployment and testing
QA/Testing instructions
Checklist for the Developer
Checklist for the Peer Reviewers