Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOTE-1163/1162: Accessibility updates - logos and search AND regions #729

Merged
merged 31 commits into from
Jun 3, 2024

Conversation

mlloydbixal
Copy link
Contributor

@mlloydbixal mlloydbixal commented May 29, 2024

Jira ticket

VOTE-1163
VOTE-1162

Description

VOTE-1163
-Adds site logo alt text "Vote.gov - Home"
-No updates to USA logo alt text because it was already implemented
-No updates to GSA logo alt text because it was already implemented
-Adds aria label for search input to say "submit" instead of "commit"

VOTE-1162
-Switches nav elements for divs/sections in main section where they were not nav items (sitemap, registration tool)
-Removes the redundant "navigation" from "primary navigation"
-The vote.gov logo region issue was already resolved
-Removes redundant "search" and now just says "Search region"
-Identifier region now says ""External election resources"
-Removes "introduction region"
-The issue with the collage of images showing as a region doesn't appear to be an issue

Deployment and testing

QA/Testing instructions

  1. lando retune
  2. Inspect logos and search button for expected alt text

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

rayestrada and others added 24 commits December 5, 2023 08:28
Sprint 47: Release candidate to STAGE
MId-sprint 48: HOTFIX release
VOTE-570 add section alert field to nvrf field taxonomy
Sprint 48: release candidate to STAGE
Sprint 49: release candidate for STAGE
Sprint 50: release candidate to STAGE
Sprint 51: Release Candidate to STAGE
Sprint 52: release candidate to STAGE
VOTE-541: remove taxonomy pages from static site after generation
HOTFIX for missing hmn configuration
HOTFIX clean out unused config
Sprint 53: release candidate to STAGE
Sprint 54: release candidate to STAGE
Sprint 55: Release candidate to STAGE
Sprint 56: release candidate to STAGE
Sprint 57: release candidate to STAGE
Sprint 58: Release candidate to STAGE
Sprint 59: Release candidate to STAGE
Sprint 59: additional fixes
@mlloydbixal mlloydbixal requested a review from clmedders May 29, 2024 20:47
clmedders
clmedders previously approved these changes May 30, 2024
Copy link
Contributor

@clmedders clmedders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - i checked that the logo had alt text and check that the others flagged already had them and did a screen reader check for the search bar

@clmedders clmedders dismissed their stale review May 30, 2024 16:32

Hit approve by mistake

@mlloydbixal mlloydbixal changed the title VOTE-1163: Accessibility updates to logos and search VOTE-1163/1162: Accessibility updates - logos and search AND regions May 30, 2024
Copy link
Contributor

@clmedders clmedders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment above.. also found a bug with the search field but will post in ticket

@clmedders clmedders self-requested a review June 3, 2024 15:16
@clmedders clmedders merged commit a4138df into dev Jun 3, 2024
3 checks passed
@clmedders clmedders deleted the feature/VOTE-1163/accessibility branch June 3, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants