Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VOTE-2020 Add GTM code to votegov theme #730

Merged
merged 1 commit into from
May 30, 2024
Merged

VOTE-2020 Add GTM code to votegov theme #730

merged 1 commit into from
May 30, 2024

Conversation

rayestrada
Copy link
Contributor

@rayestrada rayestrada commented May 30, 2024 •
edited
Loading

Jira ticket

https://cm-jira.usa.gov/browse/VOTE-2020

Description

Add GTM code to votegov theme

Deployment and testing

Post-deploy steps

  1. run lando drush cr

QA/Testing instructions

  1. Visit http://vote-gov.lndo.site/ and confirm in the source code that the script and no script tags are present

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@rayestrada rayestrada requested a review from clmedders May 30, 2024 00:09
clmedders
clmedders approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@clmedders clmedders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... i checked that the spirits were added to the right spot and that they matched the ticket

@clmedders clmedders merged commit 0e84a61 into dev May 30, 2024
3 checks passed
@clmedders clmedders deleted the feature/VOTE-2020-gtm-update branch May 30, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clmedders clmedders clmedders approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rayestrada @clmedders