Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOTE-1107: Move non li items in list #731

Merged
merged 1 commit into from
May 31, 2024

Conversation

mlloydbixal
Copy link
Contributor

Jira ticket

Insert a link to the Jira ticket (e.g VOTE-XXX).

Description

-Moves span elements in list inside of their list items so the list is a valid list
-Issue of close button being inside nav element is already resolved

Deployment and testing

Post-deploy steps

  1. Insert any required steps to take before beginning test.

QA/Testing instructions

  1. confirm all direct elements in primary navigation list are list items

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@mlloydbixal mlloydbixal requested a review from clmedders May 30, 2024 20:14
Copy link
Contributor

@clmedders clmedders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - checked that the span was placed correctly and ran both AXE and wave and no error related to this was found

@clmedders clmedders merged commit 931520e into dev May 31, 2024
3 checks passed
@rayestrada rayestrada deleted the feature/VOTE-1107/accessibility-nav-li branch June 18, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants