Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOTE-1937: PX design updates - State pages #733

Merged
merged 4 commits into from
May 31, 2024

Conversation

mlloydbixal
Copy link
Contributor

@mlloydbixal mlloydbixal commented May 31, 2024

Jira ticket

VOTE-1937

Description

Includes some changes to masthead shared by basic pages plus additional rule to use narrow container on state page content.

Deployment and testing

QA/Testing instructions

  1. Compare a state page to latest PX designs https://www.figma.com/design/u82ICmmHNBKpE1Tw4nsO0K/Vote.gov-Redesign-2024-(Master)?node-id=8989-24652&m=dev

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@mlloydbixal mlloydbixal requested a review from rayestrada May 31, 2024 00:41
@daniel-crowder daniel-crowder self-requested a review May 31, 2024 16:21
daniel-crowder
daniel-crowder previously approved these changes May 31, 2024
@daniel-crowder daniel-crowder self-requested a review May 31, 2024 18:37
@daniel-crowder daniel-crowder merged commit c411836 into dev May 31, 2024
3 checks passed
@rayestrada rayestrada deleted the feature/VOTE-1937/px-state-pages branch June 18, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants