Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/vote 1939 voter guide refinements #740

Merged
merged 16 commits into from
Jun 6, 2024

Conversation

clmedders
Copy link
Contributor

@clmedders clmedders commented Jun 5, 2024

Jira ticket

Vote-1939

Description

Updates to the voter guide template from PX review

Updates made:

  • Updated page masthead to have hero mark-up
  • Updated the hero style sheets for the vote-hero--dark to help match the style guide
    • mobile view for image
    • breadcrumb update
    • background color
  • added side page nav and fixed bug with the active state
  • added a static image

Follow up tasks:
These have been ticketed out

  • migrate hero paragraph type to be a component
  • update feature card to be a view
  • update space between breadcrumb and header
  • update image to be dynamic

Deployment and testing

Post-deploy steps

  1. run lando retune and cd into votegov theme and run npm run build

QA/Testing instructions

  1. visit voter guide page and compare to design here
  2. check on various browsers and refer to ticketed out work to check if something is off to make sure it will be addressed later on

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@clmedders clmedders marked this pull request as ready for review June 5, 2024 14:34
@clmedders clmedders requested a review from rayestrada June 5, 2024 14:34
@rayestrada
Copy link
Contributor

@clmedders I made some refinements in the latest commit you are welcome to review and ask questions.

@rayestrada rayestrada merged commit f647244 into dev Jun 6, 2024
3 checks passed
@rayestrada rayestrada deleted the feature/vote-1939-voter-guide-refinements branch June 18, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants