Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOTE-2040: Legacy site alert block content #746

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

mlloydbixal
Copy link
Contributor

@mlloydbixal mlloydbixal commented Jun 7, 2024

Jira ticket

VOTE-2040

Description

Replaces hard coded alert component for legacy site link with a content block. The block has been created on production where ID is 20. Translations being added on production.

Deployment and testing

Post deploy

  1. Test again with translations and block id that are on production

QA/Testing instructions

  1. Create site alert block (this should have id 20 but if not update line 60 of page.html.twig to match your environment)
  2. Confirm block shows on pages where translation is marked as outdated
  3. Add translations for block and confirm it translates

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@mlloydbixal mlloydbixal requested a review from clmedders June 7, 2024 17:49
Copy link
Contributor

@clmedders clmedders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - was able to test that the block only worked when a translation was outdated and worked as expected

@clmedders clmedders merged commit bf9b13b into dev Jun 10, 2024
3 checks passed
@clmedders clmedders deleted the feature/VOTE-2040/legacy-banner branch June 10, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants