Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VOTE-2016 Add image field to state and voter guide content types #747

Merged
merged 1 commit into from
Jun 10, 2024
Merged

VOTE-2016 Add image field to state and voter guide content types #747

merged 1 commit into from
Jun 10, 2024

Conversation

rayestrada
Copy link
Contributor

@rayestrada rayestrada commented Jun 7, 2024 •
edited by clmedders
Loading

Jira ticket

https://cm-jira.usa.gov/browse/VOTE-2016

Description

Add image field to state and voter guide content types

Deployment and testing

Post-deploy steps

  1. run lando retune

QA/Testing instructions

  1. Visit http://vote-gov.lndo.site/node/7/edit and add an image to the state page
  2. Confirm that the image displays on the state page.
  3. Visit http://vote-gov.lndo.site/node/82/edit and add an image to the voter guide
  4. Confirm that the image displays on the voter guide page.

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@rayestrada rayestrada requested a review from clmedders June 7, 2024 23:29
clmedders
clmedders approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@clmedders clmedders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - was able to upload image and was displayed

@clmedders clmedders merged commit 3f25efb into dev Jun 10, 2024
3 checks passed
@clmedders clmedders deleted the feature/VOTE-2016-add-image-ct branch June 10, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clmedders clmedders clmedders approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rayestrada @clmedders