Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vote-2024: Cypress and USWDS Updates #748

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

clmedders
Copy link
Contributor

@clmedders clmedders commented Jun 10, 2024

Jira ticket

Vote-2024

Description

Updating Cypress to 13.11.0 - Link to changelog: closes out #724

Updating USWDS to 3.8.1 - Link to changelong closes out #738

  • note: there were a few updates to components that we use but seem to be minor and after review did not cause any issues or regressions

Deployment and testing

Post-deploy steps

  1. cd into testing and run npm install
  2. cd into votegov theme and run npm install

QA/Testing instructions

  1. while in testing npm the follow scripts npm run cy:frontEnd, npm run cy:backEnd and npm run cy:open - this will open the runner and can run single testing to ensure all are passing
  2. cd into votegov theme and run npm run build and visit the site and check that there are no major regressions. Checking the footer in Spanish and various buttons for regressions

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@clmedders clmedders changed the title Vote-2024: Update Cypress - 13.11.0 Vote-2024: Cypress and USWDS Updates Jun 10, 2024
@clmedders clmedders marked this pull request as ready for review June 10, 2024 15:44
@clmedders clmedders requested a review from mlloydbixal June 10, 2024 15:44
Copy link
Contributor

@mlloydbixal mlloydbixal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't notice any issues or regressions, tests are passing

@mlloydbixal mlloydbixal merged commit b7f3bdf into dev Jun 10, 2024
3 checks passed
@rayestrada rayestrada deleted the feature/vote-2024-cypress-update branch June 18, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants