Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/vote 2067 breadcrumb space #751

Merged
merged 5 commits into from
Jun 17, 2024

Conversation

clmedders
Copy link
Contributor

@clmedders clmedders commented Jun 11, 2024

Jira ticket

Vote-2067

Description

Adding style to the div wrapping the breadcrumb block to add a margin top style to the following element.

Also updated the page-title template to removed the div and just make it into an h1 and update the styles for the component.

Side by side of computed styles:
Screenshot 2024-06-12 at 9 17 56 AM

Deployment and testing

Post-deploy steps

  1. run lando retune and cd into the votegov theme and run npm run build

QA/Testing instructions

  1. visit the following pages voter guide, about page, state selection page, accessibility page, site map and inspect the heading element and check that the margin top has 5rem/80px
  2. also add {{ drupal_entity('block', 'votegov_breadcrumbs') }} above the vote-hero__heading element in the hero file and check that the same styles are applied to the hero element on the home page as well.

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@clmedders clmedders marked this pull request as ready for review June 12, 2024 13:29
@rayestrada rayestrada merged commit 327b410 into dev Jun 17, 2024
3 checks passed
@rayestrada rayestrada deleted the feature/vote-2067-breadcrumb-space branch June 18, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants