Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style a11y toolbar #754

Merged
merged 5 commits into from
Jun 12, 2024
Merged

Style a11y toolbar #754

merged 5 commits into from
Jun 12, 2024

Conversation

rayestrada
Copy link
Contributor

@rayestrada rayestrada commented Jun 12, 2024 •
edited
Loading

Jira ticket

VOTE-2003

Description

Style the a11y toolbar when logged in. We will make it visible when the high contrast work is completed.

Deployment and testing

Post-deploy steps

  1. cd into votegov theme and run npm run build
  2. run lando drush cr

QA/Testing instructions

  1. login and visit the homepage http://vote-gov.lndo.site/
  2. test the a11y button function
  3. test on LTR and RTL
  4. test on mobile and desktop

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@rayestrada rayestrada requested a review from mlloydbixal June 12, 2024 15:57
@rayestrada rayestrada merged commit 2c1afa0 into dev Jun 12, 2024
3 checks passed
@rayestrada rayestrada deleted the feature/VOTE-2003-a11y-toolbar branch June 18, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlloydbixal mlloydbixal mlloydbixal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rayestrada @mlloydbixal