Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration cleanup #757

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Configuration cleanup #757

merged 1 commit into from
Jun 17, 2024

Conversation

daniel-crowder
Copy link
Contributor

@daniel-crowder daniel-crowder commented Jun 12, 2024

Jira ticket

VOTE-2078 - User Configuration Updates - Site Builder Role
VOTE-2017 - Hmong language removal

Description

Update configurations to include user roles as partials in config splits settings.
Remove Hmong related config as the language is being removed.

Deployment and testing

Post-deploy steps

None

QA/Testing instructions

Testing results should not change from tests done in referenced tickets, above. But if you need to, the testing instructions are available in ticket PRs below.
VOTE-2078 - #741
VOTE-2017 - #745

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

…ng them as partials for config splits. Remove unneeded Homong translation config file.
@daniel-crowder daniel-crowder changed the title Cleanup configuration for user roles for semantic purposes by includi… Configuration cleanup Jun 17, 2024
@daniel-crowder daniel-crowder marked this pull request as ready for review June 17, 2024 15:33
@rayestrada rayestrada merged commit 37608ee into dev Jun 17, 2024
3 checks passed
@rayestrada rayestrada deleted the configuration-cleanup branch June 18, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants