Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VOTE-946 add background color option to hero for landing pages #760

Merged
merged 1 commit into from
Jun 14, 2024
Merged

VOTE-946 add background color option to hero for landing pages #760

merged 1 commit into from
Jun 14, 2024

Conversation

rayestrada
Copy link
Contributor

@rayestrada rayestrada commented Jun 13, 2024 •
edited
Loading

Jira ticket

VOTE-946

Description

Add background color options for hero component.

Deployment and testing

Post-deploy steps

  1. run lando retune

QA/Testing instructions

  1. visit http://vote-gov.lndo.site/your-vote-safe
  2. edit the page and select background color in the hero as "dark"
  3. view the page and see that the style of the hero has changed to the alternative version

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@rayestrada rayestrada requested a review from mlloydbixal June 13, 2024 16:12
@mlloydbixal mlloydbixal merged commit a2295ad into dev Jun 14, 2024
3 checks passed
@rayestrada rayestrada deleted the feature/VOTE-946-hero-options branch June 18, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlloydbixal mlloydbixal mlloydbixal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rayestrada @mlloydbixal