Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VOTE-2123 Configure site menus to restrict untranslated pages #761

Merged
merged 1 commit into from
Jun 13, 2024
Merged

VOTE-2123 Configure site menus to restrict untranslated pages #761

merged 1 commit into from
Jun 13, 2024

Conversation

rayestrada
Copy link
Contributor

@rayestrada rayestrada commented Jun 13, 2024 •
edited
Loading

Jira ticket

VOTE-2123

Description

See commit message

Deployment and testing

Post-deploy steps

  1. run lando retune

QA/Testing instructions

  1. visit http://vote-gov.lndo.site/es/mapa-del-sitio
  2. confirm that only translated pages show in main menu, in sitemap and in footer (you can create a spanish translation of a page to test)

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

clmedders
clmedders approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@clmedders clmedders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@clmedders clmedders merged commit 934ecc2 into dev Jun 13, 2024
3 checks passed
@clmedders clmedders deleted the feature/VOTE-2123-menu-translation-settings branch June 13, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clmedders clmedders clmedders approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rayestrada @clmedders