Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VOTE-2118 wrap node query in preprocess in conditional #764

Merged
merged 1 commit into from
Jun 13, 2024
Merged

VOTE-2118 wrap node query in preprocess in conditional #764

merged 1 commit into from
Jun 13, 2024

Conversation

rayestrada
Copy link
Contributor

@rayestrada rayestrada commented Jun 13, 2024 •
edited by SamiraMSadat
Loading

Jira ticket

https://cm-jira.usa.gov/browse/VOTE-2118

Description

Fix login page error

Deployment and testing

Post-deploy steps

  1. run lando drush cr

QA/Testing instructions

  1. visit http://vote-gov.lndo.site/user/login confirm there is no error and the page loads

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@rayestrada rayestrada requested a review from SamiraMSadat June 13, 2024 22:12
@rayestrada rayestrada merged commit 5414b7a into dev Jun 13, 2024
3 checks passed
@rayestrada rayestrada deleted the bug/VOTE-2118-preprocess-fix branch June 18, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamiraMSadat SamiraMSadat SamiraMSadat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rayestrada @SamiraMSadat