Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOTE-2082/2083: High contrast styling on basic and state pages #766

Merged
merged 7 commits into from
Jun 17, 2024

Conversation

mlloydbixal
Copy link
Contributor

@mlloydbixal mlloydbixal commented Jun 14, 2024

Jira ticket

VOTE-2082
VOTE-2083

Description

Insert a brief summary of the changes included in this PR and any additional information or context which may help the reviewer.

Deployment and testing

Post-deploy steps

  1. Insert any required steps to take before beginning test.

QA/Testing instructions

  1. lando retune
  2. npm run build in theme
  3. Navigate to a state page and a basic page
  4. Toggle the high contrast button and verify styles
  5. Toggle back to default, verify styles

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@mlloydbixal mlloydbixal requested a review from clmedders June 14, 2024 17:53
Copy link
Contributor

@clmedders clmedders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made a comment above and there is a merge conflict.. will leave some feedback in ticket as well

@clmedders clmedders requested a review from rayestrada June 17, 2024 20:46
@rayestrada rayestrada merged commit 0ad7961 into dev Jun 17, 2024
3 checks passed
@rayestrada rayestrada deleted the feature/VOTE-2082/px-high-contrast branch June 18, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants