Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VOTE-2125 make mobile menu close button accessible by keyboard #770

Merged
merged 1 commit into from
Jun 17, 2024
Merged

VOTE-2125 make mobile menu close button accessible by keyboard #770

merged 1 commit into from
Jun 17, 2024

Conversation

rayestrada
Copy link
Contributor

@rayestrada rayestrada commented Jun 17, 2024 •
edited
Loading

Jira ticket

https://cm-jira.usa.gov/browse/VOTE-2125

Description

Make mobile menu close button accessible from keyboard.

Deployment and testing

Post-deploy steps

  1. run npm run build in votegov theme directory
  2. run lando drush cr

QA/Testing instructions

  1. visit http://vote-gov.lndo.site/
  2. resize browser window to trigger mobile menu display
  3. using your keyboard tab to trigger the mobile menu and close it using the close button.

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@rayestrada rayestrada requested a review from clmedders June 17, 2024 17:55
@clmedders clmedders merged commit 453b02f into dev Jun 17, 2024
3 checks passed
@clmedders clmedders deleted the bug/VOTE-2125-a11y-menu-close branch June 17, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clmedders clmedders clmedders approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rayestrada @clmedders