Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vote-2124: Make image alt text optional #777

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Vote-2124: Make image alt text optional #777

merged 1 commit into from
Jun 24, 2024

Conversation

clmedders
Copy link
Contributor

@clmedders clmedders commented Jun 21, 2024 •
edited
Loading

Jira ticket

Vote-2124

Description

Updating the alt text to be optional and no longer required

Deployment and testing

Post-deploy steps

  1. run lando retune

QA/Testing instructions

  1. log in as an admin and update the homepage hero by adding an image and verify that the alt text filed is no longer required.

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@clmedders clmedders requested a review from mlloydbixal June 21, 2024 17:58
@clmedders clmedders marked this pull request as ready for review June 21, 2024 17:58
@mlloydbixal mlloydbixal merged commit 6f95be1 into dev Jun 24, 2024
3 checks passed
@rayestrada rayestrada deleted the bug/vote-2124-remove-alt-text branch July 2, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlloydbixal mlloydbixal mlloydbixal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clmedders @mlloydbixal