Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vote-2108: Copy style updates #778

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Vote-2108: Copy style updates #778

merged 1 commit into from
Jun 24, 2024

Conversation

clmedders
Copy link
Contributor

@clmedders clmedders commented Jun 22, 2024 •
edited
Loading

Jira ticket

Vote-2108

Description

Update to copy styles across the site for consistency. Updating all headers to be merriweather and all body copy to be roboto

Deployment and testing

Post-deploy steps

  1. run lando retune cd into the votegov theme and run npm run build

QA/Testing instructions

  1. visit a voter guide page and inspect headers and body copy and verify that the correct styles are being applied.

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@clmedders clmedders marked this pull request as ready for review June 24, 2024 13:02
@clmedders clmedders requested a review from SamiraMSadat June 24, 2024 13:03
@SamiraMSadat SamiraMSadat merged commit 2fb7741 into dev Jun 24, 2024
3 checks passed
@rayestrada rayestrada deleted the feature/vote-2108-style-update branch July 2, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamiraMSadat SamiraMSadat SamiraMSadat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clmedders @SamiraMSadat