Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vote-2194: Fix to breadcrumb style #779

Merged
merged 3 commits into from
Jun 24, 2024
Merged

Conversation

clmedders
Copy link
Contributor

@clmedders clmedders commented Jun 22, 2024

Jira ticket

Vote-2194

Description

The breadcrumb style that was added last sprint was not getting applied to the voter guide... i update the class name to be more specific in the targeting

Deployment and testing

Post-deploy steps

  1. run lando retune and cd into the votegov theme

QA/Testing instructions

  1. visit a voterguide and inspect the hero and check that the header is getting a margin top of 80px/5rem applied

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@clmedders clmedders marked this pull request as ready for review June 24, 2024 13:10
@clmedders clmedders requested a review from SamiraMSadat June 24, 2024 13:10
@SamiraMSadat SamiraMSadat merged commit 0b25934 into dev Jun 24, 2024
3 checks passed
@rayestrada rayestrada deleted the bug/vote-2194-breadcrumb-update branch July 2, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants