Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vote-2108: Remove type--secondary from files #786

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Vote-2108: Remove type--secondary from files #786

merged 1 commit into from
Jun 26, 2024

Conversation

clmedders
Copy link
Contributor

@clmedders clmedders commented Jun 25, 2024 •
edited by rayestrada
Loading

Jira ticket

Vote-2108

Description

Follow up PR to remove type--secondary from scss and template files

Deployment and testing

Post-deploy steps

  1. run lando retune and cd into votegov them and run npm run build

QA/Testing instructions

  1. verify that type--secondary is not in the codebase and load site and verify now major visual regressions

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@clmedders clmedders marked this pull request as ready for review June 25, 2024 19:09
@clmedders clmedders requested a review from rayestrada June 25, 2024 19:09
@rayestrada rayestrada merged commit ee8a043 into dev Jun 26, 2024
3 checks passed
@rayestrada rayestrada deleted the feature/vote-2108-remove-secondary-type branch July 2, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rayestrada rayestrada rayestrada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clmedders @rayestrada