Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOTE-2047: Style felony module #787

Merged
merged 9 commits into from
Jun 27, 2024
Merged

Conversation

mlloydbixal
Copy link
Contributor

@mlloydbixal mlloydbixal commented Jun 25, 2024

Jira ticket

VOTE-2047

Description

Styles felony modules, including high contrast mode.

Deployment and testing

Post-deploy steps

  1. Iando retune
  2. npm run build
  3. Navigate to http://vote-gov.lndo.site/voting-after-felony-conviction
  4. You may have to edit the page and add content for the modules by selecting "add states double deck card" in the "add basic" dropdown
  5. Confirm styles are correct. Figma link: https://www.figma.com/design/u82ICmmHNBKpE1Tw4nsO0K/Vote.gov-Redesign-2024-(Master)?node-id=9061-29360&m=dev
  6. Check all screen sizes and high contrast mode

QA/Testing instructions

  1. Insert steps to test and confirm the result meets the "definition of done".

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@mlloydbixal mlloydbixal requested a review from clmedders June 25, 2024 20:07
Copy link
Contributor

@clmedders clmedders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a few comments above

@clmedders clmedders self-requested a review June 27, 2024 13:23
clmedders
clmedders previously approved these changes Jun 27, 2024
@clmedders clmedders requested a review from rayestrada June 27, 2024 13:40
@rayestrada rayestrada changed the title VOTE-2046: Style felony module VOTE-2047: Style felony module Jun 27, 2024
@rayestrada rayestrada merged commit e54673f into dev Jun 27, 2024
3 checks passed
@rayestrada rayestrada deleted the feature/VOTE-2047/felony-modules branch July 2, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants