Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VOTE-2200: Add Portuguese config file #789

Merged
merged 1 commit into from
Jun 27, 2024
Merged

VOTE-2200: Add Portuguese config file #789

merged 1 commit into from
Jun 27, 2024

Conversation

mlloydbixal
Copy link
Contributor

@mlloydbixal mlloydbixal commented Jun 26, 2024 •
edited by clmedders
Loading

Jira ticket

VOTE-2200

Description

Adds missing Portuguese config file to fix language selector dropdown selection.

Deployment and testing

QA/Testing instructions

  1. lando retune
  2. make sure configuration is imported
  3. Check that both names for Portuguese appear in language selector dropdown, matching the current Vote.gov site.

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@mlloydbixal mlloydbixal requested a review from clmedders June 26, 2024 16:04
clmedders
clmedders approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@clmedders clmedders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - checked that both are showing like on the current site and that it was consistent with each translation

@clmedders clmedders merged commit 5c0c50a into dev Jun 27, 2024
3 checks passed
@clmedders clmedders deleted the bug/VOTE-2200/lang-selector branch June 27, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clmedders clmedders clmedders approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mlloydbixal @clmedders