Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOTE-2199: Fix logo focus outline #792

Merged
merged 2 commits into from
Jun 27, 2024
Merged

VOTE-2199: Fix logo focus outline #792

merged 2 commits into from
Jun 27, 2024

Conversation

mlloydbixal
Copy link
Contributor

@mlloydbixal mlloydbixal commented Jun 26, 2024

Jira ticket

VOTE-2199

Description

This fixes the issue on safari where the focus state outline box around the logo was not positioned correctly by adding inline-block rule to the wrapping element.

Deployment and testing

QA/Testing instructions

  1. lando retune
  2. npm run build
  3. Using safari browser
  4. test the focus outline position by selecting the logo in the header

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@mlloydbixal mlloydbixal requested a review from clmedders June 26, 2024 17:57
@mlloydbixal mlloydbixal marked this pull request as ready for review June 26, 2024 18:17
@clmedders clmedders merged commit f0bbd36 into dev Jun 27, 2024
3 checks passed
@clmedders clmedders deleted the bug/VOTE-2199/logo-focus branch June 27, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants