Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/vote 2077/state selector axe error #800

Merged
merged 9 commits into from
Jul 1, 2024

Conversation

SamiraMSadat
Copy link
Contributor

@SamiraMSadat SamiraMSadat commented Jun 27, 2024

Jira ticket

https://cm-jira.usa.gov/browse/VOTE-2077

Description

Remove listbox role from the state selector. It is not the correct aria role, and caused some axe errors.

Deployment and testing

Post-deploy steps

  1. lando retune

QA/Testing instructions

  1. Visit the registration landing page and run axe tools (in browser or cypress)
  2. Confirm there are no axe errors produced by the state selector.

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@SamiraMSadat SamiraMSadat requested a review from clmedders June 27, 2024 20:49
Copy link
Contributor

@clmedders clmedders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks that there are merge conflicts

@clmedders clmedders self-requested a review June 28, 2024 18:55
@clmedders clmedders requested a review from rayestrada June 28, 2024 19:09
@SamiraMSadat SamiraMSadat requested a review from clmedders July 1, 2024 15:36
@rayestrada rayestrada dismissed clmedders’s stale review July 1, 2024 16:17

The requested revisions are resolved.

@rayestrada rayestrada merged commit f38169b into dev Jul 1, 2024
3 checks passed
@rayestrada rayestrada deleted the bug/VOTE-2077/state-selector-axe-error branch July 2, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants