Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vote-2127: Removed USWDS External Link Notification #809

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

clmedders
Copy link
Contributor

@clmedders clmedders commented Jul 2, 2024

Jira ticket

Vote-2127

Description

Removing the default voice over notification coming from USWDS to let the user know they are on an external link. Since we have added custom strings that will be translated this will no longer be needed.

Deployment and testing

Post-deploy steps

  1. cd into the votegov theme and run a npm run dev and wait for build to complete

QA/Testing instructions

  1. Visit home page and turn on voiceover (for mac can use command+f5) and use the tab button to navigate to an external link
  2. The expected behavior is you should not hear "external link" at the start of the command but only the custom message we have applied.
  3. To verify that this is targeting the right setting visit web/themes/custom/votegov/src/sass/_uswds-settings.scss and update the setting by adding This is a test after a rebuild you should now hear this at the start of the link.

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@clmedders clmedders requested a review from mlloydbixal July 3, 2024 19:20
@clmedders clmedders marked this pull request as ready for review July 3, 2024 19:20
Copy link
Contributor

@mlloydbixal mlloydbixal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, approving

@clmedders clmedders requested a review from rayestrada July 8, 2024 13:28
@rayestrada rayestrada merged commit 428ea0d into dev Jul 9, 2024
3 checks passed
@rayestrada rayestrada deleted the feature/vote-2127-ext-link branch August 14, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants