Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vote- 2234 high contrast breadcrumb #815

Merged
merged 3 commits into from
Jul 5, 2024
Merged

Vote- 2234 high contrast breadcrumb #815

merged 3 commits into from
Jul 5, 2024

Conversation

SamiraMSadat
Copy link
Contributor

@SamiraMSadat SamiraMSadat commented Jul 3, 2024 •
edited by rayestrada
Loading

Jira ticket

https://cm-jira.usa.gov/browse/VOTE-2234

Description

  1. Change the vote-dark-link mixin to have a yellow hover state for high contrast
  2. Correctly apply the mixin to the breadcrumb

Deployment and testing

Post-deploy steps

  1. re-build the theme
  2. lando retune

QA/Testing instructions

  1. Visit the register to vote page and confirm the high contrast style is being applied correctly to the breadcrumb
  2. Repeat on the Guide to voting page breadcrumb

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@SamiraMSadat SamiraMSadat requested a review from rayestrada July 3, 2024 19:24
@rayestrada rayestrada merged commit 896174a into dev Jul 5, 2024
3 checks passed
@rayestrada rayestrada deleted the feature/VOTE-2234/high-contrast-breadcrumb branch August 14, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rayestrada rayestrada rayestrada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SamiraMSadat @rayestrada