Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOTE-2249 update voter guide listing config #818

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

rayestrada
Copy link
Contributor

@rayestrada rayestrada commented Jul 5, 2024

Jira ticket

VOTE-2249

Description

Update voter guide listing on voter guide pages to be in ascending chronological order and excluding the current page.

Deployment and testing

Post-deploy steps

  1. run lando retune

QA/Testing instructions

  1. visit http://vote-gov.lndo.site/guide-to-voting/preparing-age-18-and-under
  2. Confirm that the guide doesn't show up in the listing of guides below the page content.
  3. Confirm that "voting as a college student" is first and "voting after a felony conviction" is last

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@rayestrada rayestrada requested a review from mlloydbixal July 5, 2024 23:27
Copy link
Contributor

@mlloydbixal mlloydbixal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mlloydbixal mlloydbixal merged commit 5bf3952 into dev Jul 8, 2024
3 checks passed
@rayestrada rayestrada deleted the feature/2249-voter-guide-listing branch August 14, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants