Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOTE-2166: RTL styles #821

Merged
merged 5 commits into from
Jul 9, 2024
Merged

VOTE-2166: RTL styles #821

merged 5 commits into from
Jul 9, 2024

Conversation

mlloydbixal
Copy link
Contributor

@mlloydbixal mlloydbixal commented Jul 8, 2024

Jira ticket

VOTE-2166

Description

Fixes styling issues for RTL languages for:

  • footer
  • buttons
  • breadcrumb
  • mobile nav menu

Deployment and testing

QA/Testing instructions

  1. lando retune
  2. npm run build in theme directory
  3. Navigate to http://vote-gov.lndo.site/ar/register/alaska
  4. Confirm these issues are resolved:

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@mlloydbixal mlloydbixal requested a review from rayestrada July 8, 2024 14:36
@rayestrada rayestrada merged commit 0c7b57d into dev Jul 9, 2024
3 checks passed
@rayestrada rayestrada deleted the feature/VOTE-2166/rtl-styles branch August 14, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants