Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vote-2229: Adding aria-label="secondary" to footer nav #826

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Vote-2229: Adding aria-label="secondary" to footer nav #826

merged 1 commit into from
Jul 9, 2024

Conversation

clmedders
Copy link
Contributor

@clmedders clmedders commented Jul 8, 2024 •
edited
Loading

Jira ticket

Vote-2229

Description

Adding aria-label="secondary" to the footer element to address issues brought up by the USA.gov team

see W3 Documentation for reference. This update will match the same mark up for the aria-label found in the main nav

Deployment and testing

Post-deploy steps

  1. run lando retune

QA/Testing instructions

  1. inspect the footer and check that aria-label="Secondary" is present

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@clmedders clmedders marked this pull request as ready for review July 9, 2024 17:49
@mlloydbixal mlloydbixal merged commit cbe89f9 into dev Jul 9, 2024
3 checks passed
@rayestrada rayestrada deleted the feature/vote-2229-accessability-update branch August 14, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlloydbixal mlloydbixal mlloydbixal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clmedders @mlloydbixal