Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOTE-2291 fix primary image proportions on state and basic page #827

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

rayestrada
Copy link
Contributor

@rayestrada rayestrada commented Jul 8, 2024

Jira ticket

https://cm-jira.usa.gov/browse/VOTE-2291

Description

Fix the image proportions on state and basic page primary image display.

Deployment and testing

Post-deploy steps

  1. run npm run build in votegov theme directory
  2. run lando retune

QA/Testing instructions

  1. log into the site and visit http://vote-gov.lndo.site/about-us
  2. Upload an image and test the display of the image at desktop, tablet and mobile in LTR and RTL.
  3. visit http://vote-gov.lndo.site/register/alabama
  4. Upload an image and test the display of the image at desktop, tablet and mobile in LTR and RTL.

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@rayestrada rayestrada force-pushed the bug/VOTE-2291-node-primary-image branch from 9472902 to becb21a Compare July 8, 2024 23:07
@rayestrada rayestrada marked this pull request as ready for review July 8, 2024 23:08
@rayestrada rayestrada requested a review from mlloydbixal July 8, 2024 23:08
Copy link
Contributor

@mlloydbixal mlloydbixal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and works

@mlloydbixal mlloydbixal merged commit 06795df into dev Jul 9, 2024
3 checks passed
@rayestrada rayestrada deleted the bug/VOTE-2291-node-primary-image branch August 14, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants