Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vote-2230: Updates from W3 markup tests #829

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

clmedders
Copy link
Contributor

@clmedders clmedders commented Jul 9, 2024

Jira ticket

Vote-2230

Description

Minor markup edits found my usa.gov team... I also used the same tool and checked the other pages, however there were errors that I couldn't found/reproduce or it is flagging something that is needed to be used.

Deployment and testing

Post-deploy steps

  1. run lando retune

QA/Testing instructions

  1. Inspect mark up and verify that it is no longer present and review code removed and ensure that was nothing taken out that is needed

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@clmedders clmedders marked this pull request as ready for review July 9, 2024 00:50
@rayestrada rayestrada merged commit 4afc37a into dev Jul 9, 2024
3 checks passed
@rayestrada rayestrada deleted the feature/vote-2230-w3c-markup branch August 14, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants