Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VOTE-2295: switch logo img to inline svg, add high contrast fill colors #831

Merged
merged 3 commits into from
Jul 11, 2024
Merged

VOTE-2295: switch logo img to inline svg, add high contrast fill colors #831

merged 3 commits into from
Jul 11, 2024

Conversation

mlloydbixal
Copy link
Contributor

@mlloydbixal mlloydbixal commented Jul 9, 2024 •
edited by rayestrada
Loading

Jira ticket

VOTE-2295

Description

Changes logo fill colors on high contrast mode, replaces image tag with inline svg

Deployment and testing

QA/Testing instructions

  1. lando retune
  2. npm run build
  3. toggle high contrast mode on and off
  4. confirm svg colors match

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@rayestrada rayestrada merged commit 833f791 into dev Jul 11, 2024
3 checks passed
@rayestrada rayestrada deleted the feature/VOTE-2295/px-hc-logo branch August 14, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rayestrada rayestrada rayestrada approved these changes

@clmedders clmedders Awaiting requested review from clmedders

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mlloydbixal @rayestrada