Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/vote 2278 basic module #833

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Bug/vote 2278 basic module #833

merged 2 commits into from
Jul 10, 2024

Conversation

clmedders
Copy link
Contributor

@clmedders clmedders commented Jul 9, 2024

Jira ticket

Vote-2278

Description

Adding parent class target for basic-module styles to only be applied to landing pages and not on others.

Before and After
Before: Screenshot 2024-07-09 at 3 03 55 PM

After: Screenshot 2024-07-09 at 3 04 10 PM

Deployment and testing

Post-deploy steps

  1. run lando retune and cd into votegov theme and run npm run build

QA/Testing instructions

  1. Log in with lando drush uli and go to the felony voter guide, edit the page and add both a double deck card and a basic module under the new card and very that the content to taking up the correct width.
  2. Spot check other pages such as Your vote is safe page and verify there are no regressions.

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@clmedders clmedders marked this pull request as ready for review July 9, 2024 20:27
@clmedders clmedders requested a review from rayestrada July 9, 2024 20:27
@rayestrada rayestrada merged commit 2ba53e9 into dev Jul 10, 2024
3 checks passed
@rayestrada rayestrada deleted the bug/vote-2278-basic-module branch August 14, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants