Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VOTE-974 theme audit optimizations #838

Merged
merged 1 commit into from
Jul 11, 2024
Merged

VOTE-974 theme audit optimizations #838

merged 1 commit into from
Jul 11, 2024

Conversation

rayestrada
Copy link
Contributor

@rayestrada rayestrada commented Jul 10, 2024 •
edited
Loading

Jira ticket

https://cm-jira.usa.gov/browse/VOTE-974

Description

Theme optimization based on audit. Remove unused files, optimizing image assets, removing unused variables.

Deployment and testing

Post-deploy steps

  1. run npm run build in votegov theme
  2. run lando drush cr

QA/Testing instructions

  1. Confirm that compiling the theme results in no errors
  2. visit http://vote-gov.lndo.site/ and confirm that the there aren't any regressions related to modified files

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@mlloydbixal mlloydbixal merged commit 4e08d2c into dev Jul 11, 2024
3 checks passed
@rayestrada rayestrada deleted the feature/VOTE-974-theme-audit branch August 14, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlloydbixal mlloydbixal mlloydbixal approved these changes

@clmedders clmedders Awaiting requested review from clmedders

@SamiraMSadat SamiraMSadat Awaiting requested review from SamiraMSadat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rayestrada @mlloydbixal