Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vote-2349: Add "On this page" transltion for spanish #839

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

clmedders
Copy link
Contributor

@clmedders clmedders commented Jul 11, 2024

Jira ticket

Vote-2349

Description

Adding the Spanish translation for "On this page" for the in-page nav.

Screenshot 2024-07-11 at 9 52 31 AM

Deployment and testing

Post-deploy steps

  1. run lando retune

QA/Testing instructions

  1. log in as an admin locally and visit http://vote-gov.lndo.site/node/82/translations and add a spanish translation (just save the page no need to worry about other text).
  2. verify that On this page has been translated.

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@clmedders clmedders requested a review from rayestrada July 11, 2024 13:54
@clmedders clmedders marked this pull request as ready for review July 11, 2024 13:54
@rayestrada rayestrada merged commit 37c914f into dev Jul 11, 2024
3 checks passed
@rayestrada rayestrada deleted the feature/vote-2349-nav-translation branch August 14, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants