Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOTE-2330 Update voter guide listing view to only display results fro… #840

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

rayestrada
Copy link
Contributor

@rayestrada rayestrada commented Jul 11, 2024

…m the current language

Jira ticket

https://cm-jira.usa.gov/browse/VOTE-2330

Description

Update voter guide listing view on voter guide pages to only show results from the current language.

Deployment and testing

Post-deploy steps

  1. run lando retune

QA/Testing instructions

  1. visit http://vote-gov.lndo.site/node/82/translations and add a spanish translation of this voter guide
  2. visit http://vote-gov.lndo.site/node/83/translations and add a spnaish translation of this voter guide
  3. visit http://vote-gov.lndo.site/guide-to-voting/new-united-states-citizen and confirm Spanish voter guides are not displaying in the listing
  4. visit http://vote-gov.lndo.site/es/guide-to-voting/new-united-states-citizen and confirm that only the Spanish voter guide displaying in the listing

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@rayestrada rayestrada requested a review from mlloydbixal July 11, 2024 16:21
@mlloydbixal mlloydbixal merged commit 6299fbb into dev Jul 11, 2024
3 checks passed
@rayestrada rayestrada deleted the bug/VOTE-2330-voter-guide-listing-translation branch August 14, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants