Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOTE-2334: Accessibility controls border contrast #842

Merged
merged 3 commits into from
Jul 17, 2024

Conversation

mlloydbixal
Copy link
Contributor

@mlloydbixal mlloydbixal commented Jul 11, 2024

Jira ticket

VOTE-2334

Description

Changes border color variables to be WCAG compliant. Also gives buttons z-index on hover to bring focus outline forward.

Deployment and testing

Post-deploy steps

  1. lando retune
  2. npm run build
  3. toggle accessibility buttons
  4. confirm contrast

QA/Testing instructions

  1. Insert steps to test and confirm the result meets the "definition of done".

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@mlloydbixal mlloydbixal requested a review from SamiraMSadat July 11, 2024 23:00
SamiraMSadat
SamiraMSadat previously approved these changes Jul 12, 2024
@SamiraMSadat SamiraMSadat merged commit 9b9bdec into dev Jul 17, 2024
3 checks passed
@rayestrada rayestrada deleted the feature/VOTE-2334/acc-controls-outline branch August 14, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants