Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOTE-2328: Move #main-content id to fix andi tab order #843

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

mlloydbixal
Copy link
Contributor

@mlloydbixal mlloydbixal commented Jul 11, 2024

VOTE-2328

Insert a link to the Jira ticket (e.g VOTE-XXX).

Description

ANDI screen reader was generating an extra 'X' where the skip nav link element was to flag where it was removed from tab order. To fix, #main-content id has been to the container of the main content in each instance.

Deployment and testing

QA/Testing instructions

  1. lando retune
  2. Using ANDI, turn on tab order
Screenshot 2024-07-11 at 7 35 28 PM 3. Confirm skip navigation works the same as expected 4. Confirm the "X" span isn't being added under the main nav Screenshot 2024-07-11 at 7 36 31 PM

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@mlloydbixal mlloydbixal requested a review from rayestrada July 11, 2024 23:36
@rayestrada rayestrada merged commit 9e9e372 into dev Jul 11, 2024
3 checks passed
@rayestrada rayestrada deleted the feature/VOTE-2328/skipnav-tab-order branch August 14, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants