Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VOTE-2373: Update partner string in footer - EN/ES #844

Merged
merged 1 commit into from
Jul 16, 2024
Merged

VOTE-2373: Update partner string in footer - EN/ES #844

merged 1 commit into from
Jul 16, 2024

Conversation

mlloydbixal
Copy link
Contributor

@mlloydbixal mlloydbixal commented Jul 12, 2024 •
edited
Loading

Jira ticket

VOTE-2373

Description

Updates english string to:
Visit our partner site to find more information about voting in the United States.

Updates spanish string to:
Visite el sitio web de nuestro colaborador para encontrar más información sobre las elecciones en Estados Unidos.

Deployment and testing

QA/Testing instructions

  1. lando retune
  2. Confirm English string on footer
  3. Switch to Spanish and confirm translation

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@rayestrada rayestrada marked this pull request as ready for review July 16, 2024 15:04
@rayestrada rayestrada requested a review from clmedders July 16, 2024 15:04
@clmedders clmedders merged commit 3e20351 into dev Jul 16, 2024
3 checks passed
@clmedders clmedders deleted the feature/VOTE-2373/footer-strings-es branch July 16, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clmedders clmedders clmedders approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mlloydbixal @clmedders