Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOTE-2375 Enable translation on double deck card component #846

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

rayestrada
Copy link
Contributor

Jira ticket

https://cm-jira.usa.gov/browse/VOTE-2375

Description

Enable translation on double deck card component

Deployment and testing

Post-deploy steps

  1. run lando retune

QA/Testing instructions

  1. visit http://vote-gov.lndo.site/guide-to-voting/after-felony-conviction
  2. Edit the page and add a double deck card in english and publish
  3. Create a new translation of the page for spanish
  4. Edit the double deck card content and publish
  5. Confirm that you can save without error and that the spanish content shows on the spanish page and the english content on the english page

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@daniel-crowder daniel-crowder merged commit 5937f54 into dev Jul 12, 2024
3 checks passed
@rayestrada rayestrada deleted the bug/VOTE-2375-translate-dd-card branch August 14, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants